diff options
| author | Colin Ian King <colin.king@canonical.com> | 2021-04-09 19:27:34 +0200 |
|---|---|---|
| committer | Darrick J. Wong <djwong@kernel.org> | 2021-04-09 19:27:34 +0200 |
| commit | 3b6dd9a9aeeada19d0c820ff68e979243a888bb6 (patch) | |
| tree | 8ff00b5de6e1979ee2f5566105024ca1893db41a | |
| parent | xfs: get rid of the ip parameter to xchk_setup_* (diff) | |
| download | linux-3b6dd9a9aeeada19d0c820ff68e979243a888bb6.tar.xz linux-3b6dd9a9aeeada19d0c820ff68e979243a888bb6.zip | |
xfs: fix return of uninitialized value in variable error
A previous commit removed a call to xfs_attr3_leaf_read that
assigned an error return code to variable error. We now have
a few early error return paths to label 'out' that return
error if error is set; however error now is uninitialized
so potentially garbage is being returned. Fix this by setting
error to zero to restore the original behaviour where error
was zero at the label 'restart'.
Addresses-Coverity: ("Uninitialized scalar variable")
Fixes: 07120f1abdff ("xfs: Add xfs_has_attr and subroutines")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed-by: Brian Foster <bfoster@redhat.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
| -rw-r--r-- | fs/xfs/libxfs/xfs_attr.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c index 472b3039eabb..902e5f7e6642 100644 --- a/fs/xfs/libxfs/xfs_attr.c +++ b/fs/xfs/libxfs/xfs_attr.c @@ -928,6 +928,7 @@ restart: * Search to see if name already exists, and get back a pointer * to where it should go. */ + error = 0; retval = xfs_attr_node_hasname(args, &state); if (retval != -ENOATTR && retval != -EEXIST) goto out; |