diff options
| author | Max Staudt <max@enpas.org> | 2024-02-07 17:36:44 +0100 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.com> | 2024-04-03 21:53:39 +0200 |
| commit | 46089080a8e1c9a16c5967063986f31031bd218f (patch) | |
| tree | 4d69321e3a61f9bf0ef2b0e40c4fb60e0666e780 | |
| parent | HID: playstation: DS4: Fix LED blinking (diff) | |
| download | linux-46089080a8e1c9a16c5967063986f31031bd218f.tar.xz linux-46089080a8e1c9a16c5967063986f31031bd218f.zip | |
HID: playstation: DS4: Don't fail on FW/HW version request
Some third-party controllers can't report firmware/hardware version.
Unlike for the DualSense, the driver does not use these values for
anything in the DualShock 4 case, but merely exposes them via sysfs.
They will simply be 0x0.
Signed-off-by: Max Staudt <max@enpas.org>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
| -rw-r--r-- | drivers/hid/hid-playstation.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/hid/hid-playstation.c b/drivers/hid/hid-playstation.c index 7f50e13601f0..df50ca4dab90 100644 --- a/drivers/hid/hid-playstation.c +++ b/drivers/hid/hid-playstation.c @@ -2558,8 +2558,8 @@ static struct ps_device *dualshock4_create(struct hid_device *hdev) ret = dualshock4_get_firmware_info(ds4); if (ret) { - hid_err(hdev, "Failed to get firmware info from DualShock4\n"); - return ERR_PTR(ret); + hid_warn(hdev, "Failed to get firmware info from DualShock4\n"); + hid_warn(hdev, "HW/FW version data in sysfs will be invalid.\n"); } ret = ps_devices_list_add(ps_dev); |