diff options
| author | Sergey Shtylyov <s.shtylyov@omprussia.ru> | 2021-03-14 21:34:27 +0100 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2021-05-18 23:17:46 +0200 |
| commit | 4a24efa16e7db02306fb5db84518bb0a7ada5a46 (patch) | |
| tree | fd54d66ae21e404e024dda2f7bfb696e4fa80569 | |
| parent | sata: nv: fix debug format string mismatch (diff) | |
| download | linux-4a24efa16e7db02306fb5db84518bb0a7ada5a46.tar.xz linux-4a24efa16e7db02306fb5db84518bb0a7ada5a46.zip | |
sata_highbank: fix deferred probing
The driver overrides the error codes returned by platform_get_irq() to
-EINVAL, so if it returns -EPROBE_DEFER, the driver would fail the probe
permanently instead of the deferred probing. Switch to propagating the
error code upstream, still checking/overriding IRQ0 as libata regards it
as "no IRQ" (thus polling) anyway...
Fixes: 9ec36cafe43b ("of/irq: do irq resolution in platform_get_irq")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
Link: https://lore.kernel.org/r/105b456d-1199-f6e9-ceb7-ffc5ba551d1a@omprussia.ru
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | drivers/ata/sata_highbank.c | 6 |
1 files changed, 4 insertions, 2 deletions
diff --git a/drivers/ata/sata_highbank.c b/drivers/ata/sata_highbank.c index 64b2ef15ec19..8440203e835e 100644 --- a/drivers/ata/sata_highbank.c +++ b/drivers/ata/sata_highbank.c @@ -469,10 +469,12 @@ static int ahci_highbank_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq <= 0) { + if (irq < 0) { dev_err(dev, "no irq\n"); - return -EINVAL; + return irq; } + if (!irq) + return -EINVAL; hpriv = devm_kzalloc(dev, sizeof(*hpriv), GFP_KERNEL); if (!hpriv) { |