diff options
| author | Rajeshwar R Shinde <coolrrsh@gmail.com> | 2023-08-07 16:49:42 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2023-08-07 19:37:54 +0200 |
| commit | 4f5177458ba97734149897c5d4d44f85b8fe0348 (patch) | |
| tree | 85295839cf2c1f2c14eb1be7d50ac2d9056e34e9 | |
| parent | spi: cadence-quadspi: switch to use modern name (diff) | |
| download | linux-4f5177458ba97734149897c5d4d44f85b8fe0348.tar.xz linux-4f5177458ba97734149897c5d4d44f85b8fe0348.zip | |
spi: spi-mpc52xx-psc: Fix an unsigned comparison that can never be negative
In struct mpc52xx_psc_spi, the variable 'irq' is declared as an unsigned int.
The comparison of variable 'irq' with signed int operand is incorrect. Also,
the return value from the call to platform_get_irq(pdev,0) is int and it is
assigned to an unsigned int variable 'irq', thus redeclaring the type of
variable 'irq' to signed int.
This fixes warning such as:
drivers/spi/spi-mpc52xx-psc.c:332:5-13:
WARNING: Unsigned expression compared with zero: mps -> irq < 0
Signed-off-by: Rajeshwar R Shinde <coolrrsh@gmail.com>
Link: https://lore.kernel.org/r/20230807144942.30317-2-coolrrsh@gmail.com
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | drivers/spi/spi-mpc52xx-psc.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/spi-mpc52xx-psc.c b/drivers/spi/spi-mpc52xx-psc.c index 9a1a080fb688..795c08594a4d 100644 --- a/drivers/spi/spi-mpc52xx-psc.c +++ b/drivers/spi/spi-mpc52xx-psc.c @@ -29,7 +29,7 @@ struct mpc52xx_psc_spi { /* driver internal data */ struct mpc52xx_psc __iomem *psc; struct mpc52xx_psc_fifo __iomem *fifo; - unsigned int irq; + int irq; u8 bits_per_word; struct completion done; |