diff options
| author | Tudor Ambarus <tudor.ambarus@microchip.com> | 2021-12-15 12:01:07 +0100 |
|---|---|---|
| committer | Vinod Koul <vkoul@kernel.org> | 2022-01-05 11:20:03 +0100 |
| commit | 506875c30fc5bf92246060bc3b4c38799646266b (patch) | |
| tree | 9463c6b93b3be1abb297ea6c3eeb2fd8c4bdffff | |
| parent | dmaengine: at_xdmac: Print debug message after realeasing the lock (diff) | |
| download | linux-506875c30fc5bf92246060bc3b4c38799646266b.tar.xz linux-506875c30fc5bf92246060bc3b4c38799646266b.zip | |
dmaengine: at_xdmac: Fix concurrency over chan's completed_cookie
Caller of dma_cookie_complete is expected to hold a lock to prevent
concurrency over the channel's completed cookie marker. Call
dma_cookie_complete() with the lock held.
Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver")
Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
Link: https://lore.kernel.org/r/20211215110115.191749-5-tudor.ambarus@microchip.com
Signed-off-by: Vinod Koul <vkoul@kernel.org>
| -rw-r--r-- | drivers/dma/at_xdmac.c | 3 |
1 files changed, 1 insertions, 2 deletions
diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 7d3560acedbb..83c031207530 100644 --- a/drivers/dma/at_xdmac.c +++ b/drivers/dma/at_xdmac.c @@ -1703,11 +1703,10 @@ static void at_xdmac_tasklet(struct tasklet_struct *t) } txd = &desc->tx_dma_desc; - + dma_cookie_complete(txd); at_xdmac_remove_xfer(atchan, desc); spin_unlock_irq(&atchan->lock); - dma_cookie_complete(txd); if (txd->flags & DMA_PREP_INTERRUPT) dmaengine_desc_get_callback_invoke(txd, NULL); |