diff options
| author | Aleksandr Mishin <amishin@t-argos.ru> | 2024-07-03 21:10:07 +0200 |
|---|---|---|
| committer | Mark Brown <broonie@kernel.org> | 2024-07-04 13:42:25 +0200 |
| commit | 5080808c3339de2220c602ab7c7fa23dc6c1a5a3 (patch) | |
| tree | 1947c01be8cd85e3f282ea74285683d5c34c40ab | |
| parent | ASoC: codecs: wcd939x: Fix typec mux and switch leak during device removal (diff) | |
| download | linux-5080808c3339de2220c602ab7c7fa23dc6c1a5a3.tar.xz linux-5080808c3339de2220c602ab7c7fa23dc6c1a5a3.zip | |
ASoC: amd: Adjust error handling in case of absent codec device
acpi_get_first_physical_node() can return NULL in several cases (no such
device, ACPI table error, reference count drop to 0, etc).
Existing check just emit error message, but doesn't perform return.
Then this NULL pointer is passed to devm_acpi_dev_add_driver_gpios()
where it is dereferenced.
Adjust this error handling by adding error code return.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: 02527c3f2300 ("ASoC: amd: add Machine driver for Jadeite platform")
Signed-off-by: Aleksandr Mishin <amishin@t-argos.ru>
Link: https://patch.msgid.link/20240703191007.8524-1-amishin@t-argos.ru
Signed-off-by: Mark Brown <broonie@kernel.org>
| -rw-r--r-- | sound/soc/amd/acp-es8336.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/sound/soc/amd/acp-es8336.c b/sound/soc/amd/acp-es8336.c index e079b3218c6f..3756b8bef17b 100644 --- a/sound/soc/amd/acp-es8336.c +++ b/sound/soc/amd/acp-es8336.c @@ -203,8 +203,10 @@ static int st_es8336_late_probe(struct snd_soc_card *card) codec_dev = acpi_get_first_physical_node(adev); acpi_dev_put(adev); - if (!codec_dev) + if (!codec_dev) { dev_err(card->dev, "can not find codec dev\n"); + return -ENODEV; + } ret = devm_acpi_dev_add_driver_gpios(codec_dev, acpi_es8336_gpios); if (ret) |