summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorRuan Jinjie <ruanjinjie@huawei.com>2023-08-02 01:44:52 +0200
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2023-08-02 01:47:39 +0200
commit54116d442e001e1b6bd482122043b1870998a1f3 (patch)
tree8c3e9cac6965fc96e26591aece30db8d1a7f8e6a
parentInput: tca6416-keypad - switch to using input core's polling features (diff)
downloadlinux-54116d442e001e1b6bd482122043b1870998a1f3.tar.xz
linux-54116d442e001e1b6bd482122043b1870998a1f3.zip
Input: rpckbd - fix the return value handle for platform_get_irq()
There is no possible for platform_get_irq() to return 0, and the return value of platform_get_irq() is more sensible to show the error reason. Signed-off-by: Ruan Jinjie <ruanjinjie@huawei.com> Link: https://lore.kernel.org/r/20230731122246.2028651-1-ruanjinjie@huawei.com Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r--drivers/input/serio/rpckbd.c8
1 files changed, 4 insertions, 4 deletions
diff --git a/drivers/input/serio/rpckbd.c b/drivers/input/serio/rpckbd.c
index ce420eb1f51b..e8a9709f32eb 100644
--- a/drivers/input/serio/rpckbd.c
+++ b/drivers/input/serio/rpckbd.c
@@ -101,12 +101,12 @@ static int rpckbd_probe(struct platform_device *dev)
int tx_irq, rx_irq;
rx_irq = platform_get_irq(dev, 0);
- if (rx_irq <= 0)
- return rx_irq < 0 ? rx_irq : -ENXIO;
+ if (rx_irq < 0)
+ return rx_irq;
tx_irq = platform_get_irq(dev, 1);
- if (tx_irq <= 0)
- return tx_irq < 0 ? tx_irq : -ENXIO;
+ if (tx_irq < 0)
+ return tx_irq;
serio = kzalloc(sizeof(struct serio), GFP_KERNEL);
rpckbd = kzalloc(sizeof(*rpckbd), GFP_KERNEL);