summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHans de Goede <hdegoede@redhat.com>2022-08-22 17:08:18 +0200
committerHans de Goede <hdegoede@redhat.com>2022-08-26 12:59:00 +0200
commit6485f72b515690bdbebc711755af096d1dc08ce2 (patch)
tree36ace4b9e696559718215ef71a3cc04abae81baa
parentplatform/x86: msi-laptop: Use MODULE_DEVICE_TABLE() (diff)
downloadlinux-6485f72b515690bdbebc711755af096d1dc08ce2.tar.xz
linux-6485f72b515690bdbebc711755af096d1dc08ce2.zip
platform/x86: msi-laptop: Drop MSI_DRIVER_VERSION
Modules carrying there own version is a practice which the kernel has stopped doing for a long time now, drop it. While dropping the version pr_info from msi_init() lets remove the somewhat useless pr_info() from msi_cleanup() as well. Signed-off-by: Hans de Goede <hdegoede@redhat.com> Link: https://lore.kernel.org/r/20220822150818.45765-2-hdegoede@redhat.com
-rw-r--r--drivers/platform/x86/msi-laptop.c7
1 files changed, 0 insertions, 7 deletions
diff --git a/drivers/platform/x86/msi-laptop.c b/drivers/platform/x86/msi-laptop.c
index 843f72200cfc..93ef8851b93e 100644
--- a/drivers/platform/x86/msi-laptop.c
+++ b/drivers/platform/x86/msi-laptop.c
@@ -53,8 +53,6 @@
#include <linux/input/sparse-keymap.h>
#include <acpi/video.h>
-#define MSI_DRIVER_VERSION "0.5"
-
#define MSI_LCD_LEVEL_MAX 9
#define MSI_EC_COMMAND_WIRELESS 0x10
@@ -1109,8 +1107,6 @@ static int __init msi_init(void)
set_auto_brightness(auto_brightness);
}
- pr_info("driver " MSI_DRIVER_VERSION " successfully loaded\n");
-
return 0;
fail_create_attr:
@@ -1156,8 +1152,6 @@ static void __exit msi_cleanup(void)
if (auto_brightness != 2)
set_auto_brightness(1);
}
-
- pr_info("driver unloaded\n");
}
module_init(msi_init);
@@ -1165,5 +1159,4 @@ module_exit(msi_cleanup);
MODULE_AUTHOR("Lennart Poettering");
MODULE_DESCRIPTION("MSI Laptop Support");
-MODULE_VERSION(MSI_DRIVER_VERSION);
MODULE_LICENSE("GPL");