diff options
| author | Guenter Roeck <linux@roeck-us.net> | 2016-12-05 03:16:48 +0100 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2016-12-12 20:33:43 +0100 |
| commit | 67b2003485ee48dcfcb5338171defa4093bba02e (patch) | |
| tree | 20c77fcbdf51360025df77bad3b22dc47690d729 | |
| parent | hwmon: (lm87) Fix overflow seen when writing voltage limit attributes (diff) | |
| download | linux-67b2003485ee48dcfcb5338171defa4093bba02e.tar.xz linux-67b2003485ee48dcfcb5338171defa4093bba02e.zip | |
hwmon: (lm85) Fix overflows seen when writing voltage limit attributes
Writes into voltage limit attributes can overflow due to an unbound
multiplication.
Reviewed-by: Jean Delvare <jdelvare@suse.de>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/lm85.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/hwmon/lm85.c b/drivers/hwmon/lm85.c index 6ff773fcaefb..29c8136ce9c5 100644 --- a/drivers/hwmon/lm85.c +++ b/drivers/hwmon/lm85.c @@ -136,7 +136,8 @@ static const int lm85_scaling[] = { /* .001 Volts */ #define SCALE(val, from, to) (((val) * (to) + ((from) / 2)) / (from)) #define INS_TO_REG(n, val) \ - clamp_val(SCALE(val, lm85_scaling[n], 192), 0, 255) + SCALE(clamp_val(val, 0, 255 * lm85_scaling[n] / 192), \ + lm85_scaling[n], 192) #define INSEXT_FROM_REG(n, val, ext) \ SCALE(((val) << 4) + (ext), 192 << 4, lm85_scaling[n]) |