diff options
| author | Loic Poulain <loic.poulain@linaro.org> | 2017-11-22 15:03:17 +0100 |
|---|---|---|
| committer | Marcel Holtmann <marcel@holtmann.org> | 2017-12-13 00:28:41 +0100 |
| commit | 67b8fbead4685b36d290a0ef91c6ddffc4920ec9 (patch) | |
| tree | 673a8729ad350b8f27384d9ca8ae9045e607ad35 | |
| parent | Bluetooth: hci_serdev: Init hci_uart proto_lock to avoid oops (diff) | |
| download | linux-67b8fbead4685b36d290a0ef91c6ddffc4920ec9.tar.xz linux-67b8fbead4685b36d290a0ef91c6ddffc4920ec9.zip | |
Bluetooth: btqcomsmd: Fix skb double free corruption
In case of hci send frame failure, skb is still owned
by the caller (hci_core) and then should not be freed.
This fixes crash on dragonboard-410c when sending SCO
packet. skb is freed by both btqcomsmd and hci_core.
Fixes: 1511cc750c3d ("Bluetooth: Introduce Qualcomm WCNSS SMD based HCI driver")
Signed-off-by: Loic Poulain <loic.poulain@linaro.org>
Signed-off-by: Marcel Holtmann <marcel@holtmann.org>
| -rw-r--r-- | drivers/bluetooth/btqcomsmd.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/bluetooth/btqcomsmd.c b/drivers/bluetooth/btqcomsmd.c index 663bed63b871..2c9a5fc9137d 100644 --- a/drivers/bluetooth/btqcomsmd.c +++ b/drivers/bluetooth/btqcomsmd.c @@ -88,7 +88,8 @@ static int btqcomsmd_send(struct hci_dev *hdev, struct sk_buff *skb) break; } - kfree_skb(skb); + if (!ret) + kfree_skb(skb); return ret; } |