summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorEric Dumazet <edumazet@google.com>2019-05-28 01:56:47 +0200
committerDavid S. Miller <davem@davemloft.net>2019-05-29 02:22:15 +0200
commit6b73d19711d0989cbdcd19c61faa0f79a1a5e466 (patch)
treed896cce4bf71785036333920ba40b885b208d280
parentselftests/net: ipv6 flowlabel (diff)
downloadlinux-6b73d19711d0989cbdcd19c61faa0f79a1a5e466.tar.xz
linux-6b73d19711d0989cbdcd19c61faa0f79a1a5e466.zip
inet: frags: uninline fqdir_init()
fqdir_init() is not fast path and is getting bigger. Signed-off-by: Eric Dumazet <edumazet@google.com> Signed-off-by: David S. Miller <davem@davemloft.net>
-rw-r--r--include/net/inet_frag.h20
-rw-r--r--net/ipv4/inet_fragment.c19
2 files changed, 20 insertions, 19 deletions
diff --git a/include/net/inet_frag.h b/include/net/inet_frag.h
index 002f23c1a1a7..94092b1ef22e 100644
--- a/include/net/inet_frag.h
+++ b/include/net/inet_frag.h
@@ -109,25 +109,7 @@ struct inet_frags {
int inet_frags_init(struct inet_frags *);
void inet_frags_fini(struct inet_frags *);
-static inline int fqdir_init(struct fqdir **fqdirp, struct inet_frags *f,
- struct net *net)
-{
- struct fqdir *fqdir = kzalloc(sizeof(*fqdir), GFP_KERNEL);
- int res;
-
- if (!fqdir)
- return -ENOMEM;
- fqdir->f = f;
- fqdir->net = net;
- res = rhashtable_init(&fqdir->rhashtable, &fqdir->f->rhash_params);
- if (res < 0) {
- kfree(fqdir);
- return res;
- }
- *fqdirp = fqdir;
- return 0;
-}
-
+int fqdir_init(struct fqdir **fqdirp, struct inet_frags *f, struct net *net);
void fqdir_exit(struct fqdir *fqdir);
void inet_frag_kill(struct inet_frag_queue *q);
diff --git a/net/ipv4/inet_fragment.c b/net/ipv4/inet_fragment.c
index 6ca9523374da..7c07aae969e6 100644
--- a/net/ipv4/inet_fragment.c
+++ b/net/ipv4/inet_fragment.c
@@ -154,6 +154,25 @@ static void fqdir_rwork_fn(struct work_struct *work)
kfree(fqdir);
}
+int fqdir_init(struct fqdir **fqdirp, struct inet_frags *f, struct net *net)
+{
+ struct fqdir *fqdir = kzalloc(sizeof(*fqdir), GFP_KERNEL);
+ int res;
+
+ if (!fqdir)
+ return -ENOMEM;
+ fqdir->f = f;
+ fqdir->net = net;
+ res = rhashtable_init(&fqdir->rhashtable, &fqdir->f->rhash_params);
+ if (res < 0) {
+ kfree(fqdir);
+ return res;
+ }
+ *fqdirp = fqdir;
+ return 0;
+}
+EXPORT_SYMBOL(fqdir_init);
+
void fqdir_exit(struct fqdir *fqdir)
{
fqdir->high_thresh = 0; /* prevent creation of new frags */