diff options
| author | Huisong Li <lihuisong@huawei.com> | 2022-11-12 03:05:28 +0100 |
|---|---|---|
| committer | Rafael J. Wysocki <rafael.j.wysocki@intel.com> | 2022-11-23 19:06:56 +0100 |
| commit | 6d7d3c287410c0ad499e478e2338dc3d7e3392b1 (patch) | |
| tree | 3d6a4de29b2b6fde6fa424af09f5f24d2d73605d | |
| parent | ACPI: PCC: Setup PCC Opregion handler only if platform interrupt is available (diff) | |
| download | linux-6d7d3c287410c0ad499e478e2338dc3d7e3392b1.tar.xz linux-6d7d3c287410c0ad499e478e2338dc3d7e3392b1.zip | |
mailbox: pcc: Reset pcc_chan_count to zero in case of PCC probe failure
Currently, 'pcc_chan_count' is remains set to a non-zero value if PCC
subspaces are parsed successfully but something else fail later during
the initial PCC probing phase. This will result in pcc_mbox_request_channel
trying to access the resources that are not initialised or allocated and
may end up in a system crash.
Reset pcc_chan_count to 0 when the PCC probe fails in order to prevent
the possible issue as described above.
Fixes: ce028702ddbc ("mailbox: pcc: Move bulk of PCCT parsing into pcc_mbox_probe")
Signed-off-by: Huisong Li <lihuisong@huawei.com>
Reviewed-by: Sudeep Holla <sudeep.holla@arm.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
| -rw-r--r-- | drivers/mailbox/pcc.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index 3c2bc0ca454c..105d46c9801b 100644 --- a/drivers/mailbox/pcc.c +++ b/drivers/mailbox/pcc.c @@ -743,6 +743,7 @@ static int __init pcc_init(void) if (IS_ERR(pcc_pdev)) { pr_debug("Err creating PCC platform bundle\n"); + pcc_chan_count = 0; return PTR_ERR(pcc_pdev); } |