diff options
| author | Vlad Buslov <vladbu@nvidia.com> | 2021-02-11 11:07:59 +0100 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2021-02-11 23:42:43 +0100 |
| commit | 6f1995523a0fac7dd4fc7d2f175604dd9f699338 (patch) | |
| tree | 0d1015a35cf1775a7f462b954acb509423461c5b | |
| parent | Merge tag 'mlx5-for-upstream-2021-02-10' of git://git.kernel.org/pub/scm/linu... (diff) | |
| download | linux-6f1995523a0fac7dd4fc7d2f175604dd9f699338.tar.xz linux-6f1995523a0fac7dd4fc7d2f175604dd9f699338.zip | |
net: fib_notifier: don't return positive values on fib registration
The function fib6_walk_continue() cannot return a positive value when
called from register_fib_notifier(), but ignoring causes static analyzer to
generate warnings in users of register_fib_notifier() that try to convert
returned error code to pointer with ERR_PTR(). Handle such case by
explicitly checking for positive error values and converting them to
-EINVAL in fib6_tables_dump().
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Suggested-by: Ido Schimmel <idosch@nvidia.com>
Signed-off-by: Vlad Buslov <vladbu@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv6/ip6_fib.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/net/ipv6/ip6_fib.c b/net/ipv6/ip6_fib.c index f43e27555725..ef9d022e693f 100644 --- a/net/ipv6/ip6_fib.c +++ b/net/ipv6/ip6_fib.c @@ -499,7 +499,7 @@ int fib6_tables_dump(struct net *net, struct notifier_block *nb, hlist_for_each_entry_rcu(tb, head, tb6_hlist) { err = fib6_table_dump(net, tb, w); - if (err < 0) + if (err) goto out; } } @@ -507,7 +507,8 @@ int fib6_tables_dump(struct net *net, struct notifier_block *nb, out: kfree(w); - return err; + /* The tree traversal function should never return a positive value. */ + return err > 0 ? -EINVAL : err; } static int fib6_dump_node(struct fib6_walker *w) |