diff options
| author | Christophe JAILLET <christophe.jaillet@wanadoo.fr> | 2020-08-21 09:58:19 +0200 |
|---|---|---|
| committer | Sagi Grimberg <sagi@grimberg.me> | 2020-08-29 01:43:57 +0200 |
| commit | 70e37988db94aba607d5491a94f80ba08e399b6b (patch) | |
| tree | beef2136a6f11764baba0d8c63a6b961a7a492c3 | |
| parent | nvme: Fix NULL dereference for pci nvme controllers (diff) | |
| download | linux-70e37988db94aba607d5491a94f80ba08e399b6b.tar.xz linux-70e37988db94aba607d5491a94f80ba08e399b6b.zip | |
nvmet-fc: Fix a missed _irqsave version of spin_lock in 'nvmet_fc_fod_op_done()'
The way 'spin_lock()' and 'spin_lock_irqsave()' are used is not consistent
in this function.
Use 'spin_lock_irqsave()' also here, as there is no guarantee that
interruptions are disabled at that point, according to surrounding code.
Fixes: a97ec51b37ef ("nvmet_fc: Rework target side abort handling")
Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Sagi Grimberg <sagi@grimberg.me>
| -rw-r--r-- | drivers/nvme/target/fc.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/nvme/target/fc.c b/drivers/nvme/target/fc.c index 55bafd56166a..e6861cc10e7d 100644 --- a/drivers/nvme/target/fc.c +++ b/drivers/nvme/target/fc.c @@ -2342,9 +2342,9 @@ nvmet_fc_fod_op_done(struct nvmet_fc_fcp_iod *fod) return; if (fcpreq->fcp_error || fcpreq->transferred_length != fcpreq->transfer_length) { - spin_lock(&fod->flock); + spin_lock_irqsave(&fod->flock, flags); fod->abort = true; - spin_unlock(&fod->flock); + spin_unlock_irqrestore(&fod->flock, flags); nvmet_req_complete(&fod->req, NVME_SC_INTERNAL); return; |