summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorTiezhu Yang <yangtiezhu@loongson.cn>2023-12-19 13:50:00 +0100
committerAndrew Morton <akpm@linux-foundation.org>2023-12-29 21:22:27 +0100
commit712afc7c410efd3ffd8cad5d25a0fcb20f320ba3 (patch)
tree17caf5e44ba10e177c6f9dad9c4c415d8afc2683
parentscripts/checkstack.pl: match all stack sizes for some archs (diff)
downloadlinux-712afc7c410efd3ffd8cad5d25a0fcb20f320ba3.tar.xz
linux-712afc7c410efd3ffd8cad5d25a0fcb20f320ba3.zip
scripts/checkstack.pl: change min_stack to 512 by default
According to Documentation/process/submit-checklist.rst, checkstack does not point out problems explicitly, but any one function that uses more than 512 bytes on the stack is a candidate for change, hence it is better to omit any stack frame sizes smaller than 512 bytes, just change min_stack to 512 by default. Link: https://lkml.kernel.org/r/20231219125008.23007-5-yangtiezhu@loongson.cn Signed-off-by: Tiezhu Yang <yangtiezhu@loongson.cn> Cc: Jonathan Corbet <corbet@lwn.net> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
-rwxr-xr-xscripts/checkstack.pl2
1 files changed, 1 insertions, 1 deletions
diff --git a/scripts/checkstack.pl b/scripts/checkstack.pl
index a564c46d6129..8e04659ef463 100755
--- a/scripts/checkstack.pl
+++ b/scripts/checkstack.pl
@@ -47,7 +47,7 @@ my (@stack, $re, $dre, $sub, $x, $xs, $funcre, $min_stack);
$min_stack = shift;
if ($min_stack eq "" || $min_stack !~ /^\d+$/) {
- $min_stack = 100;
+ $min_stack = 512;
}
$x = "[0-9a-f]"; # hex character