diff options
| author | Zhen Lei <thunder.leizhen@huawei.com> | 2021-05-08 08:25:17 +0200 |
|---|---|---|
| committer | Stefan Schmidt <stefan@datenfreihafen.org> | 2021-06-03 10:50:08 +0200 |
| commit | 79c6b8ed30e54b401c873dbad2511f2a1c525fd5 (patch) | |
| tree | fb37d32bfb966ef450b21b9f702c23113fc47111 | |
| parent | net: ieee802154: mrf24j40: Drop unneeded of_match_ptr() (diff) | |
| download | linux-79c6b8ed30e54b401c873dbad2511f2a1c525fd5.tar.xz linux-79c6b8ed30e54b401c873dbad2511f2a1c525fd5.zip | |
ieee802154: fix error return code in ieee802154_add_iface()
Fix to return a negative error code from the error handling
case instead of 0, as done elsewhere in this function.
Fixes: be51da0f3e34 ("ieee802154: Stop using NLA_PUT*().")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Zhen Lei <thunder.leizhen@huawei.com>
Link: https://lore.kernel.org/r/20210508062517.2574-1-thunder.leizhen@huawei.com
Signed-off-by: Stefan Schmidt <stefan@datenfreihafen.org>
| -rw-r--r-- | net/ieee802154/nl-phy.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/net/ieee802154/nl-phy.c b/net/ieee802154/nl-phy.c index 2cdc7e63fe17..88215b5c93aa 100644 --- a/net/ieee802154/nl-phy.c +++ b/net/ieee802154/nl-phy.c @@ -241,8 +241,10 @@ int ieee802154_add_iface(struct sk_buff *skb, struct genl_info *info) } if (nla_put_string(msg, IEEE802154_ATTR_PHY_NAME, wpan_phy_name(phy)) || - nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name)) + nla_put_string(msg, IEEE802154_ATTR_DEV_NAME, dev->name)) { + rc = -EMSGSIZE; goto nla_put_failure; + } dev_put(dev); wpan_phy_put(phy); |