diff options
| author | Fuqian Huang <huangfq.daxian@gmail.com> | 2019-07-03 18:27:00 +0200 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2019-09-06 23:20:15 +0200 |
| commit | 81b94f1477575eb9613822f2baef321e7e547119 (patch) | |
| tree | 3bf3f809d3c0950f04a7f0323fd32f13252896ee | |
| parent | clk: fix devm_platform_ioremap_resource.cocci warnings (diff) | |
| download | linux-81b94f1477575eb9613822f2baef321e7e547119.tar.xz linux-81b94f1477575eb9613822f2baef321e7e547119.zip | |
clk/ti: Use kmemdup rather than duplicating its implementation
kmemdup is introduced to duplicate a region of memory in a neat way.
Rather than kmalloc/kzalloc + memcpy, which the programmer needs to
write the size twice (sometimes lead to mistakes), kmemdup improves
readability, leads to smaller code and also reduce the chances of mistakes.
Suggestion to use kmemdup rather than using kmalloc/kzalloc + memcpy.
Signed-off-by: Fuqian Huang <huangfq.daxian@gmail.com>
Link: https://lkml.kernel.org/r/20190703162700.32091-1-huangfq.daxian@gmail.com
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
| -rw-r--r-- | drivers/clk/ti/dpll.c | 4 |
1 files changed, 1 insertions, 3 deletions
diff --git a/drivers/clk/ti/dpll.c b/drivers/clk/ti/dpll.c index 659dadb23279..f728d987ebac 100644 --- a/drivers/clk/ti/dpll.c +++ b/drivers/clk/ti/dpll.c @@ -291,14 +291,12 @@ static void __init of_ti_dpll_setup(struct device_node *node, struct dpll_data *dd = NULL; u8 dpll_mode = 0; - dd = kzalloc(sizeof(*dd), GFP_KERNEL); + dd = kmemdup(ddt, sizeof(*dd), GFP_KERNEL); clk_hw = kzalloc(sizeof(*clk_hw), GFP_KERNEL); init = kzalloc(sizeof(*init), GFP_KERNEL); if (!dd || !clk_hw || !init) goto cleanup; - memcpy(dd, ddt, sizeof(*dd)); - clk_hw->dpll_data = dd; clk_hw->ops = &clkhwops_omap3_dpll; clk_hw->hw.init = init; |