diff options
| author | Xiang Yang <xiangyang3@huawei.com> | 2023-08-10 16:06:39 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2023-08-11 11:21:07 +0200 |
| commit | 829c6524d6729d05a82575dbcc16f99be5ee843d (patch) | |
| tree | d06f71ed76f4342e5ff29a36597d042bd891ae6a | |
| parent | virtio-net: set queues after driver_ok (diff) | |
| download | linux-829c6524d6729d05a82575dbcc16f99be5ee843d.tar.xz linux-829c6524d6729d05a82575dbcc16f99be5ee843d.zip | |
net: pcs: Add missing put_device call in miic_create
The reference of pdev->dev is taken by of_find_device_by_node, so
it should be released when not need anymore.
Fixes: 7dc54d3b8d91 ("net: pcs: add Renesas MII converter driver")
Signed-off-by: Xiang Yang <xiangyang3@huawei.com>
Reviewed-by: Vladimir Oltean <olteanv@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | drivers/net/pcs/pcs-rzn1-miic.c | 10 |
1 files changed, 8 insertions, 2 deletions
diff --git a/drivers/net/pcs/pcs-rzn1-miic.c b/drivers/net/pcs/pcs-rzn1-miic.c index 323bec5e57f8..356099169003 100644 --- a/drivers/net/pcs/pcs-rzn1-miic.c +++ b/drivers/net/pcs/pcs-rzn1-miic.c @@ -313,15 +313,21 @@ struct phylink_pcs *miic_create(struct device *dev, struct device_node *np) pdev = of_find_device_by_node(pcs_np); of_node_put(pcs_np); - if (!pdev || !platform_get_drvdata(pdev)) + if (!pdev || !platform_get_drvdata(pdev)) { + if (pdev) + put_device(&pdev->dev); return ERR_PTR(-EPROBE_DEFER); + } miic_port = kzalloc(sizeof(*miic_port), GFP_KERNEL); - if (!miic_port) + if (!miic_port) { + put_device(&pdev->dev); return ERR_PTR(-ENOMEM); + } miic = platform_get_drvdata(pdev); device_link_add(dev, miic->dev, DL_FLAG_AUTOREMOVE_CONSUMER); + put_device(&pdev->dev); miic_port->miic = miic; miic_port->port = port - 1; |