diff options
| author | Yury Norov <yury.norov@gmail.com> | 2023-09-25 04:38:10 +0200 |
|---|---|---|
| committer | Yury Norov <yury.norov@gmail.com> | 2023-10-15 05:25:22 +0200 |
| commit | 82bf9bdfbce9cfa73ccd86642542159119e0419f (patch) | |
| tree | 2733705fa939edea76dfce85e433b0c903e33cfb | |
| parent | lib/bitmap: split-out string-related operations to a separate files (diff) | |
| download | linux-82bf9bdfbce9cfa73ccd86642542159119e0419f.tar.xz linux-82bf9bdfbce9cfa73ccd86642542159119e0419f.zip | |
bitmap: align __reg_op() wrappers with modern coding style
Fix comments so that scripts/kernel-doc doesn't warn, and fix for-loop
stype in bitmap_find_free_region().
CC: Rasmus Villemoes <linux@rasmusvillemoes.dk>
Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Yury Norov <yury.norov@gmail.com>
| -rw-r--r-- | lib/bitmap.c | 12 |
1 files changed, 5 insertions, 7 deletions
diff --git a/lib/bitmap.c b/lib/bitmap.c index abc5579768e9..f77243ba5e1c 100644 --- a/lib/bitmap.c +++ b/lib/bitmap.c @@ -722,8 +722,8 @@ void bitmap_fold(unsigned long *dst, const unsigned long *orig, * some size '1 << order' (a power of two), aligned to that same * '1 << order' power of two. * - * Returns 1 if REG_OP_ISFREE succeeds (region is all zero bits). - * Returns 0 in all other cases and reg_ops. + * Return: 1 if REG_OP_ISFREE succeeds (region is all zero bits). + * 0 in all other cases and reg_ops. */ enum { @@ -795,14 +795,14 @@ done: * a power (@order) of two, aligned to that power of two, which * makes the search algorithm much faster. * - * Return the bit offset in bitmap of the allocated region, + * Return: the bit offset in bitmap of the allocated region, * or -errno on failure. */ int bitmap_find_free_region(unsigned long *bitmap, unsigned int bits, int order) { unsigned int pos, end; /* scans bitmap by regions of size order */ - for (pos = 0 ; (end = pos + (1U << order)) <= bits; pos = end) { + for (pos = 0; (end = pos + BIT(order)) <= bits; pos = end) { if (!__reg_op(bitmap, pos, order, REG_OP_ISFREE)) continue; __reg_op(bitmap, pos, order, REG_OP_ALLOC); @@ -820,8 +820,6 @@ EXPORT_SYMBOL(bitmap_find_free_region); * * This is the complement to __bitmap_find_free_region() and releases * the found region (by clearing it in the bitmap). - * - * No return value. */ void bitmap_release_region(unsigned long *bitmap, unsigned int pos, int order) { @@ -837,7 +835,7 @@ EXPORT_SYMBOL(bitmap_release_region); * * Allocate (set bits in) a specified region of a bitmap. * - * Return 0 on success, or %-EBUSY if specified region wasn't + * Return: 0 on success, or %-EBUSY if specified region wasn't * free (not all bits were zero). */ int bitmap_allocate_region(unsigned long *bitmap, unsigned int pos, int order) |