diff options
| author | Ma Ke <make24@iscas.ac.cn> | 2024-09-13 11:04:12 +0200 |
|---|---|---|
| committer | Alain Volmat <alain.volmat@foss.st.com> | 2024-09-23 21:40:52 +0200 |
| commit | 831214f77037de02afc287eae93ce97f218d8c04 (patch) | |
| tree | 92ff8a616095015ba8866720716b306f17e996b9 | |
| parent | drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check (diff) | |
| download | linux-831214f77037de02afc287eae93ce97f218d8c04.tar.xz linux-831214f77037de02afc287eae93ce97f218d8c04.zip | |
drm/sti: avoid potential dereference of error pointers
The return value of drm_atomic_get_crtc_state() needs to be
checked. To avoid use of error pointer 'crtc_state' in case
of the failure.
Cc: stable@vger.kernel.org
Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes")
Signed-off-by: Ma Ke <make24@iscas.ac.cn>
Link: https://patchwork.freedesktop.org/patch/msgid/20240913090412.2022848-1-make24@iscas.ac.cn
Signed-off-by: Alain Volmat <alain.volmat@foss.st.com>
| -rw-r--r-- | drivers/gpu/drm/sti/sti_cursor.c | 3 |
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/gpu/drm/sti/sti_cursor.c b/drivers/gpu/drm/sti/sti_cursor.c index db0a1eb53532..c59fcb4dca32 100644 --- a/drivers/gpu/drm/sti/sti_cursor.c +++ b/drivers/gpu/drm/sti/sti_cursor.c @@ -200,6 +200,9 @@ static int sti_cursor_atomic_check(struct drm_plane *drm_plane, return 0; crtc_state = drm_atomic_get_crtc_state(state, crtc); + if (IS_ERR(crtc_state)) + return PTR_ERR(crtc_state); + mode = &crtc_state->mode; dst_x = new_plane_state->crtc_x; dst_y = new_plane_state->crtc_y; |