diff options
| author | Maurizio Lombardi <mlombard@redhat.com> | 2024-08-29 11:52:14 +0200 |
|---|---|---|
| committer | Keith Busch <kbusch@kernel.org> | 2024-09-03 19:05:40 +0200 |
| commit | 899d2e5a4e3d36689e8938e152f4b69a4bcc6b4d (patch) | |
| tree | b641166d3330fb904af9eb39d62c43117c2153cc | |
| parent | nvme: set BLK_FEAT_ZONED for ZNS multipath disks (diff) | |
| download | linux-899d2e5a4e3d36689e8938e152f4b69a4bcc6b4d.tar.xz linux-899d2e5a4e3d36689e8938e152f4b69a4bcc6b4d.zip | |
nvmet: Identify-Active Namespace ID List command should reject invalid nsid
nsid values of 0xFFFFFFFE and 0XFFFFFFFF should be rejected with
a status code of "Invalid Namespace or Format".
See NVMe Base Specification, Active Namespace ID list (CNS 02h).
Fixes: a07b4970f464 ("nvmet: add a generic NVMe target")
Signed-off-by: Maurizio Lombardi <mlombard@redhat.com>
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Keith Busch <kbusch@kernel.org>
| -rw-r--r-- | drivers/nvme/target/admin-cmd.c | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/drivers/nvme/target/admin-cmd.c b/drivers/nvme/target/admin-cmd.c index f7e1156ac7ec..85006b2df8ae 100644 --- a/drivers/nvme/target/admin-cmd.c +++ b/drivers/nvme/target/admin-cmd.c @@ -587,6 +587,16 @@ static void nvmet_execute_identify_nslist(struct nvmet_req *req) u16 status = 0; int i = 0; + /* + * NSID values 0xFFFFFFFE and NVME_NSID_ALL are invalid + * See NVMe Base Specification, Active Namespace ID list (CNS 02h). + */ + if (min_nsid == 0xFFFFFFFE || min_nsid == NVME_NSID_ALL) { + req->error_loc = offsetof(struct nvme_identify, nsid); + status = NVME_SC_INVALID_NS | NVME_STATUS_DNR; + goto out; + } + list = kzalloc(buf_size, GFP_KERNEL); if (!list) { status = NVME_SC_INTERNAL; |