summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorHelen Fornazier <helen.koike@collabora.com>2017-04-06 21:25:15 +0200
committerMauro Carvalho Chehab <mchehab@s-opensource.com>2017-04-19 13:15:51 +0200
commit8d1d3d004c1c5386a0c7cf2e49b9de841ec4484b (patch)
tree691f65d5d9156b021e740a929e580adfbabdec4d
parent[media] pixfmt-meta-vsp1-hgo.rst: remove spurious '-' (diff)
downloadlinux-8d1d3d004c1c5386a0c7cf2e49b9de841ec4484b.tar.xz
linux-8d1d3d004c1c5386a0c7cf2e49b9de841ec4484b.zip
[media] media-entity: only call dev_dbg_obj if mdev is not NULL
Fix kernel Oops NULL pointer deference Call dev_dbg_obj only after checking if gobj->mdev is not NULL Signed-off-by: Helen Koike <helen.koike@collabora.com> Signed-off-by: Mauro Carvalho Chehab <mchehab@s-opensource.com>
-rw-r--r--drivers/media/media-entity.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index 5640ca29da8c..bc44193efa47 100644
--- a/drivers/media/media-entity.c
+++ b/drivers/media/media-entity.c
@@ -199,12 +199,12 @@ void media_gobj_create(struct media_device *mdev,
void media_gobj_destroy(struct media_gobj *gobj)
{
- dev_dbg_obj(__func__, gobj);
-
/* Do nothing if the object is not linked. */
if (gobj->mdev == NULL)
return;
+ dev_dbg_obj(__func__, gobj);
+
gobj->mdev->topology_version++;
/* Remove the object from mdev list */