diff options
| author | Sander Vanheule <sander@svanheule.net> | 2022-01-09 15:54:34 +0100 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2022-01-17 13:16:26 +0100 |
| commit | 960dd884ddf5621ae6284cd3a42724500a97ae4c (patch) | |
| tree | 0908dd2d0f6ebed55db3aed3b3555cde7de6e5c0 | |
| parent | irqchip/realtek-rtl: Fix off-by-one in routing (diff) | |
| download | linux-960dd884ddf5621ae6284cd3a42724500a97ae4c.tar.xz linux-960dd884ddf5621ae6284cd3a42724500a97ae4c.zip | |
irqchip/realtek-rtl: Service all pending interrupts
Instead of only servicing the lowest pending interrupt line, make sure
all pending SoC interrupts are serviced before exiting the chained
handler. This adds a small overhead if only one interrupt is pending,
but should prevent rapid re-triggering of the handler.
Signed-off-by: Sander Vanheule <sander@svanheule.net>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/5082ad3cb8b4eedf55075561b93eff6570299fe1.1641739718.git.sander@svanheule.net
| -rw-r--r-- | drivers/irqchip/irq-realtek-rtl.c | 8 |
1 files changed, 6 insertions, 2 deletions
diff --git a/drivers/irqchip/irq-realtek-rtl.c b/drivers/irqchip/irq-realtek-rtl.c index 568614edd88f..50a56820c99b 100644 --- a/drivers/irqchip/irq-realtek-rtl.c +++ b/drivers/irqchip/irq-realtek-rtl.c @@ -76,16 +76,20 @@ static void realtek_irq_dispatch(struct irq_desc *desc) { struct irq_chip *chip = irq_desc_get_chip(desc); struct irq_domain *domain; - unsigned int pending; + unsigned long pending; + unsigned int soc_int; chained_irq_enter(chip, desc); pending = readl(REG(RTL_ICTL_GIMR)) & readl(REG(RTL_ICTL_GISR)); + if (unlikely(!pending)) { spurious_interrupt(); goto out; } + domain = irq_desc_get_handler_data(desc); - generic_handle_domain_irq(domain, __ffs(pending)); + for_each_set_bit(soc_int, &pending, 32) + generic_handle_domain_irq(domain, soc_int); out: chained_irq_exit(chip, desc); |