diff options
| author | NeilBrown <neilb@suse.de> | 2011-07-27 23:56:24 +0200 |
|---|---|---|
| committer | NeilBrown <neilb@suse.de> | 2011-07-27 23:56:24 +0200 |
| commit | a519b26dbe6533416d21b552053b0bf687f878d7 (patch) | |
| tree | bef24eab8604ef2275eb8f1b591ea52bd4b89194 | |
| parent | MD: generate an event when array sync is complete (diff) | |
| download | linux-a519b26dbe6533416d21b552053b0bf687f878d7.tar.xz linux-a519b26dbe6533416d21b552053b0bf687f878d7.zip | |
md: remove suspicious size_of()
When calling bioset_create we pass the size of the front_pad as
sizeof(mddev)
which looks suspicious as mddev is a pointer and so it looks like a
common mistake where
sizeof(*mddev)
was intended.
The size is actually correct as we want to store a pointer in the
front padding of the bios created by the bioset, so make the intent
more explicit by using
sizeof(mddev_t *)
Reported-by: Zdenek Kabelac <zdenek.kabelac@gmail.com>
Signed-off-by: NeilBrown <neilb@suse.de>
| -rw-r--r-- | drivers/md/md.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/md/md.c b/drivers/md/md.c index 7caa096d02f6..4279b3b58d1a 100644 --- a/drivers/md/md.c +++ b/drivers/md/md.c @@ -4497,7 +4497,8 @@ int md_run(mddev_t *mddev) } if (mddev->bio_set == NULL) - mddev->bio_set = bioset_create(BIO_POOL_SIZE, sizeof(mddev)); + mddev->bio_set = bioset_create(BIO_POOL_SIZE, + sizeof(mddev_t *)); spin_lock(&pers_lock); pers = find_pers(mddev->level, mddev->clevel); |