summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAdrian Bunk <bunk@stusta.de>2006-10-09 01:16:32 +0200
committerGreg Kroah-Hartman <gregkh@suse.de>2006-10-17 23:46:33 +0200
commitad18027f4909c8fc107056460c97dbedb6635128 (patch)
treecf15d6e79ba3324e4974634a7fa446ff10fa4381
parentUSB: ftdi-elan.c: remove dead code (diff)
downloadlinux-ad18027f4909c8fc107056460c97dbedb6635128.tar.xz
linux-ad18027f4909c8fc107056460c97dbedb6635128.zip
USB: mos7840.c: fix a check-after-dereference
This patch fixes an obvious check-after-dereference spotted by the Coverity checker. Signed-off-by: Adrian Bunk <bunk@stusta.de> Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
-rw-r--r--drivers/usb/serial/mos7840.c3
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c
index 021be39fe16e..5b71962d0351 100644
--- a/drivers/usb/serial/mos7840.c
+++ b/drivers/usb/serial/mos7840.c
@@ -2413,11 +2413,12 @@ static int mos7840_ioctl(struct usb_serial_port *port, struct file *file,
}
mos7840_port = mos7840_get_port_private(port);
- tty = mos7840_port->port->tty;
if (mos7840_port == NULL)
return -1;
+ tty = mos7840_port->port->tty;
+
dbg("%s - port %d, cmd = 0x%x", __FUNCTION__, port->number, cmd);
switch (cmd) {