summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorDmitry Torokhov <dmitry.torokhov@gmail.com>2012-10-25 08:53:01 +0200
committerDmitry Torokhov <dmitry.torokhov@gmail.com>2012-10-25 09:12:01 +0200
commitadc4633c86f3358fce676b6c7ce75055e395123a (patch)
treefea3da09a058986ba85e6645a594a8426c42f52d
parentInput: fix sparse warning in multitouch code (diff)
downloadlinux-adc4633c86f3358fce676b6c7ce75055e395123a.tar.xz
linux-adc4633c86f3358fce676b6c7ce75055e395123a.zip
Input: fix sparse warning in __input_release_device()
This fixes the following warning: drivers/input/input.c:538:23: error: incompatible types in comparison expression (different address spaces) Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
-rw-r--r--drivers/input/input.c5
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/input/input.c b/drivers/input/input.c
index 53a0ddee7872..f1be1a77edf3 100644
--- a/drivers/input/input.c
+++ b/drivers/input/input.c
@@ -534,8 +534,11 @@ EXPORT_SYMBOL(input_grab_device);
static void __input_release_device(struct input_handle *handle)
{
struct input_dev *dev = handle->dev;
+ struct input_handle *grabber;
- if (dev->grab == handle) {
+ grabber = rcu_dereference_protected(dev->grab,
+ lockdep_is_held(&dev->mutex));
+ if (grabber == handle) {
rcu_assign_pointer(dev->grab, NULL);
/* Make sure input_pass_event() notices that grab is gone */
synchronize_rcu();