diff options
| author | Mario Limonciello <mario.limonciello@amd.com> | 2022-04-11 16:38:20 +0200 |
|---|---|---|
| committer | Hans de Goede <hdegoede@redhat.com> | 2022-04-13 13:49:48 +0200 |
| commit | b0c07116c894325d40a218f558047f925e4b3bdb (patch) | |
| tree | dfb652a1c62db1b7582c7f6cfa0c19212146d87c | |
| parent | platform/x86: amd-pmc: Move FCH init to first use (diff) | |
| download | linux-b0c07116c894325d40a218f558047f925e4b3bdb.tar.xz linux-b0c07116c894325d40a218f558047f925e4b3bdb.zip | |
platform/x86: amd-pmc: Avoid reading SMU version at probe time
Currently the SMU version only used to determine whether the SMU supports
reading the idle mask. To speed up startup, move it to the first time
the idle mask is read.
This decreases the startup time from ~28500us to 100us.
Reviewed-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Link: https://lore.kernel.org/r/20220411143820.13971-3-mario.limonciello@amd.com
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
| -rw-r--r-- | drivers/platform/x86/amd-pmc.c | 8 |
1 files changed, 7 insertions, 1 deletions
diff --git a/drivers/platform/x86/amd-pmc.c b/drivers/platform/x86/amd-pmc.c index 73275e6b21e0..668a1d6c11ee 100644 --- a/drivers/platform/x86/amd-pmc.c +++ b/drivers/platform/x86/amd-pmc.c @@ -422,6 +422,13 @@ static int amd_pmc_idlemask_show(struct seq_file *s, void *unused) struct amd_pmc_dev *dev = s->private; int rc; + /* we haven't yet read SMU version */ + if (!dev->major) { + rc = amd_pmc_get_smu_version(dev); + if (rc) + return rc; + } + if (dev->major > 56 || (dev->major >= 55 && dev->minor >= 37)) { rc = amd_pmc_idlemask_read(dev, NULL, s); if (rc) @@ -875,7 +882,6 @@ static int amd_pmc_probe(struct platform_device *pdev) return err; } - amd_pmc_get_smu_version(dev); platform_set_drvdata(pdev, dev); #ifdef CONFIG_SUSPEND err = acpi_register_lps0_dev(&amd_pmc_s2idle_dev_ops); |