summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorZenghui Yu <yuzenghui@huawei.com>2024-03-27 15:23:34 +0100
committerThomas Gleixner <tglx@linutronix.de>2024-04-09 11:03:16 +0200
commitb327708798809328f21da8dc14cc8883d1e8a4b3 (patch)
tree4b2ee7f4c915b4e488b5c86f85dc5e782243dc8a
parentirqchip/alpine-msi: Fix off-by-one in allocation error path (diff)
downloadlinux-b327708798809328f21da8dc14cc8883d1e8a4b3.tar.xz
linux-b327708798809328f21da8dc14cc8883d1e8a4b3.zip
irqchip/loongson-pch-msi: Fix off-by-one on allocation error path
When pch_msi_parent_domain_alloc() returns an error, there is an off-by-one in the number of interrupts to be freed. Fix it by passing the number of successfully allocated interrupts, instead of the relative index of the last allocated one. Fixes: 632dcc2c75ef ("irqchip: Add Loongson PCH MSI controller") Signed-off-by: Zenghui Yu <yuzenghui@huawei.com> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Reviewed-by: Jiaxun Yang <jiaxun.yang@flygoat.com> Link: https://lore.kernel.org/r/20240327142334.1098-1-yuzenghui@huawei.com
-rw-r--r--drivers/irqchip/irq-loongson-pch-msi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/irqchip/irq-loongson-pch-msi.c b/drivers/irqchip/irq-loongson-pch-msi.c
index 6e1e1f011bb2..dd4d699170f4 100644
--- a/drivers/irqchip/irq-loongson-pch-msi.c
+++ b/drivers/irqchip/irq-loongson-pch-msi.c
@@ -136,7 +136,7 @@ static int pch_msi_middle_domain_alloc(struct irq_domain *domain,
err_hwirq:
pch_msi_free_hwirq(priv, hwirq, nr_irqs);
- irq_domain_free_irqs_parent(domain, virq, i - 1);
+ irq_domain_free_irqs_parent(domain, virq, i);
return err;
}