diff options
| author | Michael Walle <michael@walle.cc> | 2016-07-19 16:43:26 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2016-07-20 15:30:06 +0200 |
| commit | b53893aae441a034bf4dbbad42fe218561d7d81f (patch) | |
| tree | 06a2a47c44f4efe49f0f5921b23e9dd62f795e3b | |
| parent | hwmon: Add driver for FTS BMC chip "Teutates" (diff) | |
| download | linux-b53893aae441a034bf4dbbad42fe218561d7d81f.tar.xz linux-b53893aae441a034bf4dbbad42fe218561d7d81f.zip | |
hwmon: (adt7411) set bit 3 in CFG1 register
According to the datasheet you should only write 1 to this bit. If it is
not set, at least AIN3 will return bad values on newer silicon revisions.
Fixes: d84ca5b345c2 ("hwmon: Add driver for ADT7411 voltage and temperature sensor")
Signed-off-by: Michael Walle <michael@walle.cc>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/adt7411.c | 5 |
1 files changed, 4 insertions, 1 deletions
diff --git a/drivers/hwmon/adt7411.c b/drivers/hwmon/adt7411.c index 827c03703128..a7f886961830 100644 --- a/drivers/hwmon/adt7411.c +++ b/drivers/hwmon/adt7411.c @@ -30,6 +30,7 @@ #define ADT7411_REG_CFG1 0x18 #define ADT7411_CFG1_START_MONITOR (1 << 0) +#define ADT7411_CFG1_RESERVED_BIT3 (1 << 3) #define ADT7411_REG_CFG2 0x19 #define ADT7411_CFG2_DISABLE_AVG (1 << 5) @@ -296,8 +297,10 @@ static int adt7411_probe(struct i2c_client *client, mutex_init(&data->device_lock); mutex_init(&data->update_lock); + /* According to the datasheet, we must only write 1 to bit 3 */ ret = adt7411_modify_bit(client, ADT7411_REG_CFG1, - ADT7411_CFG1_START_MONITOR, 1); + ADT7411_CFG1_RESERVED_BIT3 + | ADT7411_CFG1_START_MONITOR, 1); if (ret < 0) return ret; |