summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorKelvin Cao <kelvin.cao@microchip.com>2021-11-19 01:38:03 +0100
committerBjorn Helgaas <bhelgaas@google.com>2021-11-19 19:14:02 +0100
commitb76521f6482d2a2a691e4eb1a496d55d73aea064 (patch)
tree7ba6c754ee46bdda93ec71276e0f9869480f336d
parentPCI/switchtec: Add Gen4 automotive device IDs (diff)
downloadlinux-b76521f6482d2a2a691e4eb1a496d55d73aea064.tar.xz
linux-b76521f6482d2a2a691e4eb1a496d55d73aea064.zip
PCI/switchtec: Declare local state_names[] as static
The local state_names[] array is constant and need not be allocated and populated each time we enter stuser_set_state(). Declare it as static. See the link below for the discussion. https://lore.kernel.org/r/20211014141859.11444-1-kelvin.cao@microchip.com/ [bhelgaas: simplify commit log] Suggested-by: Krzysztof WilczyƄski <kw@linux.com> Link: https://lore.kernel.org/r/20211119003803.2333-3-kelvin.cao@microchip.com Signed-off-by: Kelvin Cao <kelvin.cao@microchip.com> Signed-off-by: Bjorn Helgaas <bhelgaas@google.com> Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
-rw-r--r--drivers/pci/switch/switchtec.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
index 6e2d6c5ea4b5..c36c1238c604 100644
--- a/drivers/pci/switch/switchtec.c
+++ b/drivers/pci/switch/switchtec.c
@@ -122,7 +122,7 @@ static void stuser_set_state(struct switchtec_user *stuser,
{
/* requires the mrpc_mutex to already be held when called */
- const char * const state_names[] = {
+ static const char * const state_names[] = {
[MRPC_IDLE] = "IDLE",
[MRPC_QUEUED] = "QUEUED",
[MRPC_RUNNING] = "RUNNING",