diff options
| author | Dan Carpenter <error27@gmail.com> | 2023-01-24 16:20:46 +0100 |
|---|---|---|
| committer | Greg Kroah-Hartman <gregkh@linuxfoundation.org> | 2023-02-02 11:12:02 +0100 |
| commit | ba883de971d1ad018f3083d9195b8abe54d87407 (patch) | |
| tree | e52576b7fe4e5fe02dba54e5bc1d07df66c2a47b | |
| parent | USB: core: Don't hold device lock while reading the "descriptors" sysfs file (diff) | |
| download | linux-ba883de971d1ad018f3083d9195b8abe54d87407.tar.xz linux-ba883de971d1ad018f3083d9195b8abe54d87407.zip | |
usb: musb: mediatek: don't unregister something that wasn't registered
This function only calls mtk_otg_switch_init() when the ->port_mode
is MUSB_OTG so the clean up code should only call mtk_otg_switch_exit()
for that mode.
Fixes: 0990366bab3c ("usb: musb: Add support for MediaTek musb controller")
Signed-off-by: Dan Carpenter <error27@gmail.com>
Link: https://lore.kernel.org/r/Y8/3TqpqiSr0RxFH@kili
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
| -rw-r--r-- | drivers/usb/musb/mediatek.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/drivers/usb/musb/mediatek.c b/drivers/usb/musb/mediatek.c index cad991380b0c..27b9bd258340 100644 --- a/drivers/usb/musb/mediatek.c +++ b/drivers/usb/musb/mediatek.c @@ -294,7 +294,8 @@ static int mtk_musb_init(struct musb *musb) err_phy_power_on: phy_exit(glue->phy); err_phy_init: - mtk_otg_switch_exit(glue); + if (musb->port_mode == MUSB_OTG) + mtk_otg_switch_exit(glue); return ret; } |