diff options
author | Tahsin Erdogan <tahsin@google.com> | 2016-12-13 01:43:20 +0100 |
---|---|---|
committer | Linus Torvalds <torvalds@linux-foundation.org> | 2016-12-13 03:55:08 +0100 |
commit | bace9248188f64d7490ebe59fc0733db8b6f0e57 (patch) | |
tree | 593403191c322c4528f4ec8f568a330a149d2947 | |
parent | mm/filemap.c: add comment for confusing logic in page_cache_tree_insert() (diff) | |
download | linux-bace9248188f64d7490ebe59fc0733db8b6f0e57.tar.xz linux-bace9248188f64d7490ebe59fc0733db8b6f0e57.zip |
fs/fs-writeback.c: remove redundant if check
b_more_io non-empty check is already preceded by an opposite check.
Link: http://lkml.kernel.org/r/1478591249-30641-1-git-send-email-tahsin@google.com
Signed-off-by: Tahsin Erdogan <tahsin@google.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
-rw-r--r-- | fs/fs-writeback.c | 16 |
1 files changed, 7 insertions, 9 deletions
diff --git a/fs/fs-writeback.c b/fs/fs-writeback.c index 05713a5da083..ef600591d96f 100644 --- a/fs/fs-writeback.c +++ b/fs/fs-writeback.c @@ -1769,15 +1769,13 @@ static long wb_writeback(struct bdi_writeback *wb, * become available for writeback. Otherwise * we'll just busyloop. */ - if (!list_empty(&wb->b_more_io)) { - trace_writeback_wait(wb, work); - inode = wb_inode(wb->b_more_io.prev); - spin_lock(&inode->i_lock); - spin_unlock(&wb->list_lock); - /* This function drops i_lock... */ - inode_sleep_on_writeback(inode); - spin_lock(&wb->list_lock); - } + trace_writeback_wait(wb, work); + inode = wb_inode(wb->b_more_io.prev); + spin_lock(&inode->i_lock); + spin_unlock(&wb->list_lock); + /* This function drops i_lock... */ + inode_sleep_on_writeback(inode); + spin_lock(&wb->list_lock); } spin_unlock(&wb->list_lock); blk_finish_plug(&plug); |