diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2020-01-29 18:30:37 +0100 |
|---|---|---|
| committer | Johan Hovold <johan@kernel.org> | 2020-02-10 10:06:51 +0100 |
| commit | c664a4fa8f69308b8f624cff4fa1294e9aef880d (patch) | |
| tree | 87927bd71159ff06942ed92e5509f94fbb0ba342 | |
| parent | Linux 5.6-rc1 (diff) | |
| download | linux-c664a4fa8f69308b8f624cff4fa1294e9aef880d.tar.xz linux-c664a4fa8f69308b8f624cff4fa1294e9aef880d.zip | |
USB: serial: ir-usb: Silence harmless uninitialized variable warning
The "actual_length" variable might be uninitialized on some failure
paths. It's harmless but static analysis tools like Smatch complain
and at runtime the UBSan tool will likely complain as well.
Fixes: e7542bc382f8 ("USB: serial: ir-usb: make set_termios synchronous")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
| -rw-r--r-- | drivers/usb/serial/ir-usb.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/serial/ir-usb.c b/drivers/usb/serial/ir-usb.c index 79d0586e2b33..172261a908d8 100644 --- a/drivers/usb/serial/ir-usb.c +++ b/drivers/usb/serial/ir-usb.c @@ -448,7 +448,7 @@ static void ir_set_termios(struct tty_struct *tty, usb_sndbulkpipe(udev, port->bulk_out_endpointAddress), transfer_buffer, 1, &actual_length, 5000); if (ret || actual_length != 1) { - if (actual_length != 1) + if (!ret) ret = -EIO; dev_err(&port->dev, "failed to change line speed: %d\n", ret); } |