summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorAl Viro <viro@zeniv.linux.org.uk>2006-05-27 06:19:54 +0200
committerAl Viro <viro@zeniv.linux.org.uk>2006-05-27 08:26:32 +0200
commitc7c0d0a10f6e4cea95ed84adcdd37948cac09b85 (patch)
tree4af26a97e8561766a9b0da9a29926ae645dc0468
parent[PATCH] rio ->Copy() expects the sourse as first argument (diff)
downloadlinux-c7c0d0a10f6e4cea95ed84adcdd37948cac09b85.tar.xz
linux-c7c0d0a10f6e4cea95ed84adcdd37948cac09b85.zip
[PATCH] bogus order of copy_from_user() arguments
... aka "somebody forgot to swap arguments when converting from copyin()" Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
-rw-r--r--drivers/char/rio/rioboot.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/char/rio/rioboot.c b/drivers/char/rio/rioboot.c
index b9abbd0e7ec2..eca2b95343e2 100644
--- a/drivers/char/rio/rioboot.c
+++ b/drivers/char/rio/rioboot.c
@@ -280,7 +280,7 @@ int RIOBootCodeHOST(struct rio_info *p, struct DownLoad *rbp)
func_exit();
return -ENOMEM;
}
- if (copy_from_user(rbp->DataP, DownCode, rbp->Count)) {
+ if (copy_from_user(DownCode, rbp->DataP, rbp->Count)) {
kfree(DownCode);
p->RIOError.Error = COPYIN_FAILED;
func_exit();