diff options
| author | YueHaibing <yuehaibing@huawei.com> | 2019-04-30 13:34:08 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2019-04-30 17:09:28 +0200 |
| commit | c93ad1337ad06a718890a89cdd85188ff9a5a5cc (patch) | |
| tree | f77828bbcf40ea900a21c40ef914dd085038fa12 | |
| parent | net: dsa: bcm_sf2: fix buffer overflow doing set_rxnfc (diff) | |
| download | linux-c93ad1337ad06a718890a89cdd85188ff9a5a5cc.tar.xz linux-c93ad1337ad06a718890a89cdd85188ff9a5a5cc.zip | |
appletalk: Set error code if register_snap_client failed
If register_snap_client fails in atalk_init,
error code should be set, otherwise it will
triggers NULL pointer dereference while unloading
module.
Fixes: 9804501fa122 ("appletalk: Fix potential NULL pointer dereference in unregister_snap_client")
Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/appletalk/ddp.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/net/appletalk/ddp.c b/net/appletalk/ddp.c index 709d2542f729..dbe8b1993be9 100644 --- a/net/appletalk/ddp.c +++ b/net/appletalk/ddp.c @@ -1920,6 +1920,7 @@ static int __init atalk_init(void) ddp_dl = register_snap_client(ddp_snap_id, atalk_rcv); if (!ddp_dl) { pr_crit("Unable to register DDP with SNAP.\n"); + rc = -ENOMEM; goto out_sock; } |