diff options
| author | Ian Rogers <irogers@google.com> | 2023-08-23 10:08:06 +0200 |
|---|---|---|
| committer | Arnaldo Carvalho de Melo <acme@redhat.com> | 2023-08-23 13:48:49 +0200 |
| commit | cc5adb7347bed620182b345e6a3726d8f4acce01 (patch) | |
| tree | d7bd8bc9bcf4b080a8dd45431e88b23c7ff42c32 | |
| parent | perf pmu: Avoid a path name copy (diff) | |
| download | linux-cc5adb7347bed620182b345e6a3726d8f4acce01.tar.xz linux-cc5adb7347bed620182b345e6a3726d8f4acce01.zip | |
perf pmu: Move perf_pmu__set_format to pmu.y
Avoid having the function in the C and header file, as it is only used
locally by pmu.y.
Signed-off-by: Ian Rogers <irogers@google.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com>
Cc: Gaosheng Cui <cuigaosheng1@huawei.com>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: James Clark <james.clark@arm.com>
Cc: Jing Zhang <renyu.zj@linux.alibaba.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: John Garry <john.g.garry@oracle.com>
Cc: Kajol Jain <kjain@linux.ibm.com>
Cc: Kan Liang <kan.liang@linux.intel.com>
Cc: Mark Rutland <mark.rutland@arm.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ravi Bangoria <ravi.bangoria@amd.com>
Cc: Rob Herring <robh@kernel.org>
Link: https://lore.kernel.org/r/20230823080828.1460376-4-irogers@google.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
| -rw-r--r-- | tools/perf/util/pmu.c | 12 | ||||
| -rw-r--r-- | tools/perf/util/pmu.h | 1 | ||||
| -rw-r--r-- | tools/perf/util/pmu.y | 12 |
3 files changed, 12 insertions, 13 deletions
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index 7683c6749d66..40999e1fab8f 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -1417,18 +1417,6 @@ int perf_pmu__new_format(struct list_head *list, char *name, return 0; } -void perf_pmu__set_format(unsigned long *bits, long from, long to) -{ - long b; - - if (!to) - to = from; - - memset(bits, 0, BITS_TO_BYTES(PERF_PMU_FORMAT_BITS)); - for (b = from; b <= to; b++) - __set_bit(b, bits); -} - void perf_pmu__del_formats(struct list_head *formats) { struct perf_pmu_format *fmt, *tmp; diff --git a/tools/perf/util/pmu.h b/tools/perf/util/pmu.h index 7ff925224165..9c9ea40b9c71 100644 --- a/tools/perf/util/pmu.h +++ b/tools/perf/util/pmu.h @@ -231,7 +231,6 @@ void perf_pmu_error(struct list_head *list, char *name, void *scanner, char cons int perf_pmu__new_format(struct list_head *list, char *name, int config, unsigned long *bits); -void perf_pmu__set_format(unsigned long *bits, long from, long to); int perf_pmu__format_parse(int dirfd, struct list_head *head); void perf_pmu__del_formats(struct list_head *formats); bool perf_pmu__has_format(const struct perf_pmu *pmu, const char *name); diff --git a/tools/perf/util/pmu.y b/tools/perf/util/pmu.y index 3d46cca3bb94..9bd9e30791ff 100644 --- a/tools/perf/util/pmu.y +++ b/tools/perf/util/pmu.y @@ -21,6 +21,18 @@ do { \ YYABORT; \ } while (0) +static void perf_pmu__set_format(unsigned long *bits, long from, long to) +{ + long b; + + if (!to) + to = from; + + memset(bits, 0, BITS_TO_BYTES(PERF_PMU_FORMAT_BITS)); + for (b = from; b <= to; b++) + __set_bit(b, bits); +} + %} %token PP_CONFIG |