diff options
| author | Ricardo Koller <ricarkol@google.com> | 2022-01-27 04:08:54 +0100 |
|---|---|---|
| committer | Marc Zyngier <maz@kernel.org> | 2022-02-08 16:18:58 +0100 |
| commit | cc94d47ce16d4147d546e47c8248e8bd12ba5fe5 (patch) | |
| tree | 66abaa5dd93fbbf2499f808669dfabe745d5075f | |
| parent | Linux 5.17-rc3 (diff) | |
| download | linux-cc94d47ce16d4147d546e47c8248e8bd12ba5fe5.tar.xz linux-cc94d47ce16d4147d546e47c8248e8bd12ba5fe5.zip | |
kvm: selftests: aarch64: fix assert in gicv3_access_reg
The val argument in gicv3_access_reg can have any value when used for a
read, not necessarily 0. Fix the assert by checking val only for
writes.
Signed-off-by: Ricardo Koller <ricarkol@google.com>
Reported-by: Reiji Watanabe <reijiw@google.com>
Cc: Andrew Jones <drjones@redhat.com>
Reviewed-by: Andrew Jones <drjones@redhat.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220127030858.3269036-2-ricarkol@google.com
| -rw-r--r-- | tools/testing/selftests/kvm/lib/aarch64/gic_v3.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/testing/selftests/kvm/lib/aarch64/gic_v3.c b/tools/testing/selftests/kvm/lib/aarch64/gic_v3.c index 00f613c0583c..e4945fe66620 100644 --- a/tools/testing/selftests/kvm/lib/aarch64/gic_v3.c +++ b/tools/testing/selftests/kvm/lib/aarch64/gic_v3.c @@ -159,7 +159,7 @@ static void gicv3_access_reg(uint32_t intid, uint64_t offset, uint32_t cpu_or_dist; GUEST_ASSERT(bits_per_field <= reg_bits); - GUEST_ASSERT(*val < (1U << bits_per_field)); + GUEST_ASSERT(!write || *val < (1U << bits_per_field)); /* Some registers like IROUTER are 64 bit long. Those are currently not * supported by readl nor writel, so just asserting here until then. */ |