diff options
| author | Dan Carpenter <dan.carpenter@oracle.com> | 2018-06-20 12:41:51 +0200 |
|---|---|---|
| committer | Jens Axboe <axboe@kernel.dk> | 2018-06-20 20:04:06 +0200 |
| commit | ce042c183bcb94eb2919e8036473a1fc203420f9 (patch) | |
| tree | cc88e5d4ee53d4aee85e5607b1e98a9dae5de2cf | |
| parent | blk-mq-debugfs: Off by one in blk_mq_rq_state_name() (diff) | |
| download | linux-ce042c183bcb94eb2919e8036473a1fc203420f9.tar.xz linux-ce042c183bcb94eb2919e8036473a1fc203420f9.zip | |
block: sed-opal: Fix a couple off by one bugs
resp->num is the number of tokens in resp->tok[]. It gets set in
response_parse(). So if n == resp->num then we're reading beyond the
end of the data.
Fixes: 455a7b238cd6 ("block: Add Sed-opal library")
Reviewed-by: Scott Bauer <scott.bauer@intel.com>
Tested-by: Scott Bauer <scott.bauer@intel.com>
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>
| -rw-r--r-- | block/sed-opal.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/block/sed-opal.c b/block/sed-opal.c index 945f4b8610e0..e0de4dd448b3 100644 --- a/block/sed-opal.c +++ b/block/sed-opal.c @@ -877,7 +877,7 @@ static size_t response_get_string(const struct parsed_resp *resp, int n, return 0; } - if (n > resp->num) { + if (n >= resp->num) { pr_debug("Response has %d tokens. Can't access %d\n", resp->num, n); return 0; @@ -916,7 +916,7 @@ static u64 response_get_u64(const struct parsed_resp *resp, int n) return 0; } - if (n > resp->num) { + if (n >= resp->num) { pr_debug("Response has %d tokens. Can't access %d\n", resp->num, n); return 0; |