diff options
| author | Xiu Jianfeng <xiujianfeng@huawei.com> | 2022-11-22 14:36:14 +0100 |
|---|---|---|
| committer | Stephen Boyd <sboyd@kernel.org> | 2022-12-08 03:27:11 +0100 |
| commit | cfd3ffb36f0d566846163118651d868e607300ba (patch) | |
| tree | 7d9fdc1cacc38be068e57e085638a2c16d091997 | |
| parent | clk: samsung: Fix memory leak in _samsung_clk_register_pll() (diff) | |
| download | linux-cfd3ffb36f0d566846163118651d868e607300ba.tar.xz linux-cfd3ffb36f0d566846163118651d868e607300ba.zip | |
clk: st: Fix memory leak in st_of_quadfs_setup()
If st_clk_register_quadfs_pll() fails, @lock should be freed before goto
@err_exit, otherwise will cause meory leak issue, fix it.
Signed-off-by: Xiu Jianfeng <xiujianfeng@huawei.com>
Link: https://lore.kernel.org/r/20221122133614.184910-1-xiujianfeng@huawei.com
Reviewed-by: Patrice Chotard <patrice.chotard@foss.st.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
| -rw-r--r-- | drivers/clk/st/clkgen-fsyn.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/drivers/clk/st/clkgen-fsyn.c b/drivers/clk/st/clkgen-fsyn.c index d820292a381d..40df1db102a7 100644 --- a/drivers/clk/st/clkgen-fsyn.c +++ b/drivers/clk/st/clkgen-fsyn.c @@ -1020,9 +1020,10 @@ static void __init st_of_quadfs_setup(struct device_node *np, clk = st_clk_register_quadfs_pll(pll_name, clk_parent_name, datac->data, reg, lock); - if (IS_ERR(clk)) + if (IS_ERR(clk)) { + kfree(lock); goto err_exit; - else + } else pr_debug("%s: parent %s rate %u\n", __clk_get_name(clk), __clk_get_name(clk_get_parent(clk)), |