diff options
| author | Uwe Kleine-König <u.kleine-koenig@pengutronix.de> | 2024-03-06 18:50:48 +0100 |
|---|---|---|
| committer | Jiri Kosina <jkosina@suse.com> | 2024-04-03 13:23:23 +0200 |
| commit | d030061f610e038bca66c4902ad0605bc1c85b89 (patch) | |
| tree | eec0ad7d230576edd547cae6378715cb1bf51fd0 | |
| parent | Merge tag 'hid-for-linus-2024031301' of git://git.kernel.org/pub/scm/linux/ke... (diff) | |
| download | linux-d030061f610e038bca66c4902ad0605bc1c85b89.tar.xz linux-d030061f610e038bca66c4902ad0605bc1c85b89.zip | |
HID: google: hammer: Convert to platform remove callback returning void
The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is ignored (apart
from emitting a warning) and this typically results in resource leaks.
To improve here there is a quest to make the remove callback return
void. In the first step of this quest all drivers are converted to
.remove_new(), which already returns void. Eventually after all drivers
are converted, .remove_new() will be renamed to .remove().
Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.
Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Jiri Kosina <jkosina@suse.com>
| -rw-r--r-- | drivers/hid/hid-google-hammer.c | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/drivers/hid/hid-google-hammer.c b/drivers/hid/hid-google-hammer.c index c6bdb9c4ef3e..25331695ae32 100644 --- a/drivers/hid/hid-google-hammer.c +++ b/drivers/hid/hid-google-hammer.c @@ -255,7 +255,7 @@ out: return retval; } -static int cbas_ec_remove(struct platform_device *pdev) +static void cbas_ec_remove(struct platform_device *pdev) { struct cros_ec_device *ec = dev_get_drvdata(pdev->dev.parent); @@ -266,7 +266,6 @@ static int cbas_ec_remove(struct platform_device *pdev) cbas_ec_set_input(NULL); mutex_unlock(&cbas_ec_reglock); - return 0; } static const struct acpi_device_id cbas_ec_acpi_ids[] = { @@ -285,7 +284,7 @@ MODULE_DEVICE_TABLE(of, cbas_ec_of_match); static struct platform_driver cbas_ec_driver = { .probe = cbas_ec_probe, - .remove = cbas_ec_remove, + .remove_new = cbas_ec_remove, .driver = { .name = "cbas_ec", .acpi_match_table = ACPI_PTR(cbas_ec_acpi_ids), |