diff options
| author | Hugo Villeneuve <hvilleneuve@dimonoff.com> | 2022-01-17 23:57:42 +0100 |
|---|---|---|
| committer | Alexandre Belloni <alexandre.belloni@bootlin.com> | 2022-02-15 23:28:32 +0100 |
| commit | d4785b46345cc9564f883c94acc4c4de6bbfeea5 (patch) | |
| tree | 067b5fa2889d68efb5aef3253fd628f35eb85b71 | |
| parent | rtc: pcf8523: Fix GCC 12 warning (diff) | |
| download | linux-d4785b46345cc9564f883c94acc4c4de6bbfeea5.tar.xz linux-d4785b46345cc9564f883c94acc4c4de6bbfeea5.zip | |
rtc: pcf2127: use IRQ flags obtained from device tree if available
If the interrupt pin of the PCF2127 is routed to the input of a GPIO
expander using the pca953x driver, the later will only accept an IRQ
of type IRQ_TYPE_EDGE_FALLING or IRQ_TYPE_EDGE_RISING, and the IRQ
request will fail.
Therefore, allow the IRQ type to be passed from the device tree data
if available.
Signed-off-by: Hugo Villeneuve <hvilleneuve@dimonoff.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20220117225742.1252362-1-hugo@hugovil.com
| -rw-r--r-- | drivers/rtc/rtc-pcf2127.c | 13 |
1 files changed, 12 insertions, 1 deletions
diff --git a/drivers/rtc/rtc-pcf2127.c b/drivers/rtc/rtc-pcf2127.c index 81a5b1f2e68c..a2cea0c686c4 100644 --- a/drivers/rtc/rtc-pcf2127.c +++ b/drivers/rtc/rtc-pcf2127.c @@ -659,9 +659,20 @@ static int pcf2127_probe(struct device *dev, struct regmap *regmap, clear_bit(RTC_FEATURE_ALARM, pcf2127->rtc->features); if (alarm_irq > 0) { + unsigned long flags; + + /* + * If flags = 0, devm_request_threaded_irq() will use IRQ flags + * obtained from device tree. + */ + if (dev_fwnode(dev)) + flags = 0; + else + flags = IRQF_TRIGGER_LOW; + ret = devm_request_threaded_irq(dev, alarm_irq, NULL, pcf2127_rtc_irq, - IRQF_TRIGGER_LOW | IRQF_ONESHOT, + flags | IRQF_ONESHOT, dev_name(dev), dev); if (ret) { dev_err(dev, "failed to request alarm irq\n"); |