diff options
| author | Jinjie Ruan <ruanjinjie@huawei.com> | 2024-08-22 08:29:50 +0200 |
|---|---|---|
| committer | Guenter Roeck <linux@roeck-us.net> | 2024-08-27 17:11:15 +0200 |
| commit | d5733a9387c894a277e0d3d4111e968b917a7375 (patch) | |
| tree | b5c1a84bfca5ed8b1ebb94963552273832ae3758 | |
| parent | hwmon: (aspeed-g6-pwm-tacho): Simplify with scoped for each OF child loop (diff) | |
| download | linux-d5733a9387c894a277e0d3d4111e968b917a7375.tar.xz linux-d5733a9387c894a277e0d3d4111e968b917a7375.zip | |
hwmon: (aspeed-pwm-tacho): Simplify with scoped for each OF child loop
Use scoped for_each_child_of_node_scoped() when iterating over device
nodes to make code a bit simpler.
Signed-off-by: Jinjie Ruan <ruanjinjie@huawei.com>
Reviewed-by: Andrew Jeffery <andrew@codeconstruct.com.au>
Message-ID: <20240822062956.3490387-3-ruanjinjie@huawei.com>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
| -rw-r--r-- | drivers/hwmon/aspeed-pwm-tacho.c | 8 |
1 files changed, 3 insertions, 5 deletions
diff --git a/drivers/hwmon/aspeed-pwm-tacho.c b/drivers/hwmon/aspeed-pwm-tacho.c index 4acc1858d8ac..aa159bf158a3 100644 --- a/drivers/hwmon/aspeed-pwm-tacho.c +++ b/drivers/hwmon/aspeed-pwm-tacho.c @@ -907,7 +907,7 @@ static void aspeed_pwm_tacho_remove(void *data) static int aspeed_pwm_tacho_probe(struct platform_device *pdev) { struct device *dev = &pdev->dev; - struct device_node *np, *child; + struct device_node *np; struct aspeed_pwm_tacho_data *priv; void __iomem *regs; struct device *hwmon; @@ -951,12 +951,10 @@ static int aspeed_pwm_tacho_probe(struct platform_device *pdev) aspeed_create_type(priv); - for_each_child_of_node(np, child) { + for_each_child_of_node_scoped(np, child) { ret = aspeed_create_fan(dev, child, priv); - if (ret) { - of_node_put(child); + if (ret) return ret; - } } priv->groups[0] = &pwm_dev_group; |