summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorThinh Nguyen <Thinh.Nguyen@synopsys.com>2022-02-15 23:49:48 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2022-02-17 16:12:21 +0100
commite51879d85a4d58d3a6227bf2e88b770901b34ecb (patch)
tree53853cb421e4e55fe7eab3c1039426941331f31a
parentusb: host: xhci-mtk: Simplify supplies handling with regulator_bulk (diff)
downloadlinux-e51879d85a4d58d3a6227bf2e88b770901b34ecb.tar.xz
linux-e51879d85a4d58d3a6227bf2e88b770901b34ecb.zip
usb: dwc3: drd: Don't check against CONFIG_OF
The CONFIG_OF maybe set, but it may not be applicable to a device. In such case, checking against that can cause the device fail to initialize. Check against the device node (device->of_node) instead. Fixes: a102f07e4edf ("usb: dwc3: drd: Add support for usb-conn-gpio based usb-role-switch") Tested-by: Alexander Stein <alexander.stein@ew.tq-group.com> Signed-off-by: Thinh Nguyen <Thinh.Nguyen@synopsys.com> Link: https://lore.kernel.org/r/9f15580ad5810b1e5f31c241b35ebedfbfc30a3f.1644964864.git.Thinh.Nguyen@synopsys.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/usb/dwc3/drd.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/usb/dwc3/drd.c b/drivers/usb/dwc3/drd.c
index 25f322e62d3f..b60b5f7b6dff 100644
--- a/drivers/usb/dwc3/drd.c
+++ b/drivers/usb/dwc3/drd.c
@@ -560,7 +560,7 @@ static int dwc3_setup_role_switch(struct dwc3 *dwc)
if (IS_ERR(dwc->role_sw))
return PTR_ERR(dwc->role_sw);
- if (IS_ENABLED(CONFIG_OF)) {
+ if (dwc->dev->of_node) {
/* populate connector entry */
int ret = devm_of_platform_populate(dwc->dev);