summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJean Delvare <khali@linux-fr.org>2008-04-26 16:34:26 +0200
committerMark M. Hoffman <mhoffman@lightlink.com>2008-06-19 12:50:31 +0200
commited4ec814e45ae8b1596aea0a29b92f6c3614acaa (patch)
tree05190bbb539e2c383555d46d6302269788dd03ca
parenthwmon: (lm85) Fix function RANGE_TO_REG() (diff)
downloadlinux-ed4ec814e45ae8b1596aea0a29b92f6c3614acaa.tar.xz
linux-ed4ec814e45ae8b1596aea0a29b92f6c3614acaa.zip
hwmon: (adt7473) Initialize max_duty_at_overheat before use
data->max_duty_at_overheat is not updated in adt7473_update_device, so it might be used before it is initialized (if the user reads from sysfs file max_duty_at_crit before writing to it.) Signed-off-by: Jean Delvare <khali@linux-fr.org> Acked-by: Darrick J. Wong <djwong@us.ibm.com> Signed-off-by: Mark M. Hoffman <mhoffman@lightlink.com>
-rw-r--r--drivers/hwmon/adt7473.c3
1 files changed, 3 insertions, 0 deletions
diff --git a/drivers/hwmon/adt7473.c b/drivers/hwmon/adt7473.c
index c1009d6f9796..93dbf5e7ff8a 100644
--- a/drivers/hwmon/adt7473.c
+++ b/drivers/hwmon/adt7473.c
@@ -309,6 +309,9 @@ no_sensor_update:
ADT7473_REG_PWM_BHVR(i));
}
+ i = i2c_smbus_read_byte_data(client, ADT7473_REG_CFG4);
+ data->max_duty_at_overheat = !!(i & ADT7473_CFG4_MAX_DUTY_AT_OVT);
+
data->limits_last_updated = local_jiffies;
data->limits_valid = 1;