diff options
| author | Keith Busch <keith.busch@intel.com> | 2017-07-21 01:33:54 +0200 |
|---|---|---|
| committer | Bjorn Helgaas <bhelgaas@google.com> | 2017-08-03 23:51:19 +0200 |
| commit | f2586c678cb29f40a37c9c88a22b13d35484ffdc (patch) | |
| tree | 69178aed7fe474cea79029c919956d17dc6ca64b | |
| parent | PCI: vmd: Reserve IRQ pre-vector for better affinity (diff) | |
| download | linux-f2586c678cb29f40a37c9c88a22b13d35484ffdc.tar.xz linux-f2586c678cb29f40a37c9c88a22b13d35484ffdc.zip | |
PCI: vmd: Assign vector zero to all bridges
We don't want slower IRQ handlers impacting faster devices that happen to
be assigned the same VMD interrupt vector. The driver was trying to
separate such devices by checking if MSI-X wasn't used, but really we just
don't want endpoint devices to share with bridges. Most bridges may use MSI
currently, so that criteria happened to work, but newer ones may use MSI-X,
so this patch explicitly checks the device type when choosing a vector.
Signed-off-by: Keith Busch <keith.busch@intel.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
| -rw-r--r-- | drivers/pci/host/vmd.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/pci/host/vmd.c b/drivers/pci/host/vmd.c index 539da102f3d7..7e967a8784b2 100644 --- a/drivers/pci/host/vmd.c +++ b/drivers/pci/host/vmd.c @@ -183,7 +183,7 @@ static struct vmd_irq_list *vmd_next_irq(struct vmd_dev *vmd, struct msi_desc *d int i, best = 1; unsigned long flags; - if (!desc->msi_attrib.is_msix || vmd->msix_count == 1) + if (pci_is_bridge(msi_desc_to_pci_dev(desc)) || vmd->msix_count == 1) return &vmd->irqs[0]; raw_spin_lock_irqsave(&list_lock, flags); |