summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorJeongjun Park <aha310510@gmail.com>2024-10-10 19:46:19 +0200
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2024-10-11 08:27:36 +0200
commitf956052e00de211b5c9ebaa1958366c23f82ee9e (patch)
tree9c78fea51fb9e1d2ecf0c6401d37c1bd95773e90
parentLinux 6.12-rc2 (diff)
downloadlinux-f956052e00de211b5c9ebaa1958366c23f82ee9e.tar.xz
linux-f956052e00de211b5c9ebaa1958366c23f82ee9e.zip
vt: prevent kernel-infoleak in con_font_get()
font.data may not initialize all memory spaces depending on the implementation of vc->vc_sw->con_font_get. This may cause info-leak, so to prevent this, it is safest to modify it to initialize the allocated memory space to 0, and it generally does not affect the overall performance of the system. Cc: stable@vger.kernel.org Reported-by: syzbot+955da2d57931604ee691@syzkaller.appspotmail.com Fixes: 05e2600cb0a4 ("VT: Bump font size limitation to 64x128 pixels") Signed-off-by: Jeongjun Park <aha310510@gmail.com> Link: https://lore.kernel.org/r/20241010174619.59662-1-aha310510@gmail.com Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/tty/vt/vt.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/tty/vt/vt.c b/drivers/tty/vt/vt.c
index cd87e3d1291e..96842ce817af 100644
--- a/drivers/tty/vt/vt.c
+++ b/drivers/tty/vt/vt.c
@@ -4726,7 +4726,7 @@ static int con_font_get(struct vc_data *vc, struct console_font_op *op)
return -EINVAL;
if (op->data) {
- font.data = kvmalloc(max_font_size, GFP_KERNEL);
+ font.data = kvzalloc(max_font_size, GFP_KERNEL);
if (!font.data)
return -ENOMEM;
} else