diff options
| author | Kangjie Lu <kjlu@umn.edu> | 2019-03-14 07:30:59 +0100 |
|---|---|---|
| committer | Martin K. Petersen <martin.petersen@oracle.com> | 2019-03-26 03:24:30 +0100 |
| commit | fba1bdd2a9a93f3e2181ec1936a3c2f6b37e7ed6 (patch) | |
| tree | 5f398a1ac62f492a70aa3a0cff75cfbc6ac591c1 | |
| parent | scsi: aacraid: Insure we don't access PCIe space during AER/EEH (diff) | |
| download | linux-fba1bdd2a9a93f3e2181ec1936a3c2f6b37e7ed6.tar.xz linux-fba1bdd2a9a93f3e2181ec1936a3c2f6b37e7ed6.zip | |
scsi: qla4xxx: fix a potential NULL pointer dereference
In case iscsi_lookup_endpoint fails, the fix returns -EINVAL to avoid NULL
pointer dereference.
Signed-off-by: Kangjie Lu <kjlu@umn.edu>
Acked-by: Manish Rangankar <mrangankar@marvell.com>
Reviewed-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
| -rw-r--r-- | drivers/scsi/qla4xxx/ql4_os.c | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c index 16a18d5d856f..6e4f4931ae17 100644 --- a/drivers/scsi/qla4xxx/ql4_os.c +++ b/drivers/scsi/qla4xxx/ql4_os.c @@ -3203,6 +3203,8 @@ static int qla4xxx_conn_bind(struct iscsi_cls_session *cls_session, if (iscsi_conn_bind(cls_session, cls_conn, is_leading)) return -EINVAL; ep = iscsi_lookup_endpoint(transport_fd); + if (!ep) + return -EINVAL; conn = cls_conn->dd_data; qla_conn = conn->dd_data; qla_conn->qla_ep = ep->dd_data; |