summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorSudip Mukherjee <sudipm.mukherjee@gmail.com>2015-11-23 12:54:31 +0100
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>2016-02-08 07:53:40 +0100
commitfbaa72d56424553f0aa434d8816a0da7a9071415 (patch)
treedf55e81df6741004423cad033084e72b0cc93bad
parentmisc: mic: return error properly (diff)
downloadlinux-fbaa72d56424553f0aa434d8816a0da7a9071415.tar.xz
linux-fbaa72d56424553f0aa434d8816a0da7a9071415.zip
misc: mic: return error directly
Instead of jumping to a label and then returning from there lets return directly. Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org> Reviewed-by: Sudeep Dutt <sudeep.dutt@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
-rw-r--r--drivers/misc/mic/host/mic_x100.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/misc/mic/host/mic_x100.c b/drivers/misc/mic/host/mic_x100.c
index 317e25ff484c..37fa89875e1e 100644
--- a/drivers/misc/mic/host/mic_x100.c
+++ b/drivers/misc/mic/host/mic_x100.c
@@ -450,14 +450,14 @@ mic_x100_load_firmware(struct mic_device *mdev, const char *buf)
rc = mic_x100_get_boot_addr(mdev);
if (rc)
- goto done;
+ return rc;
/* load OS */
rc = request_firmware(&fw, mdev->cosm_dev->firmware, &mdev->pdev->dev);
if (rc < 0) {
dev_err(&mdev->pdev->dev,
"ramdisk request_firmware failed: %d %s\n",
rc, mdev->cosm_dev->firmware);
- goto done;
+ return rc;
}
if (mdev->bootaddr > mdev->aper.len - fw->size) {
rc = -EINVAL;