summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorBenjamin Coddington <bcodding@redhat.com>2018-10-18 21:01:49 +0200
committerTrond Myklebust <trond.myklebust@hammerspace.com>2018-10-18 23:20:57 +0200
commitfc187514d8af3a676c7bd7922439f9f5e5c6223f (patch)
tree29d62c2d0b603883a98c4d9ea897a5a91589c049
parentnfs: Fix a missed page unlock after pg_doio() (diff)
downloadlinux-fc187514d8af3a676c7bd7922439f9f5e5c6223f.tar.xz
linux-fc187514d8af3a676c7bd7922439f9f5e5c6223f.zip
nfs: remove redundant call to nfs_context_set_write_error()
We don't need to call this in the direct, read, or pnfs resend paths and the only other caller is the write path in nfs_page_async_flush() which already checks and sets the pg_error on the context. Signed-off-by: Benjamin Coddington <bcodding@redhat.com> Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
-rw-r--r--fs/nfs/pagelist.c4
1 files changed, 0 insertions, 4 deletions
diff --git a/fs/nfs/pagelist.c b/fs/nfs/pagelist.c
index 3b50edf6f883..5c4568a0804b 100644
--- a/fs/nfs/pagelist.c
+++ b/fs/nfs/pagelist.c
@@ -1174,10 +1174,6 @@ int nfs_pageio_add_request(struct nfs_pageio_descriptor *desc,
return 1;
out_failed:
- /* remember fatal errors */
- if (nfs_error_is_fatal(desc->pg_error))
- nfs_context_set_write_error(req->wb_context,
- desc->pg_error);
nfs_pageio_error_cleanup(desc);
return 0;
}