diff options
| author | David Ahern <dsa@cumulusnetworks.com> | 2017-04-22 18:10:13 +0200 |
|---|---|---|
| committer | David S. Miller <davem@davemloft.net> | 2017-04-24 20:07:18 +0200 |
| commit | fc1f8f4f310ac65b1337e2d7ba52ae4ff2b7c849 (patch) | |
| tree | 2bade33a266614f621dae64b929322ec52d04ba2 | |
| parent | ravb: Double free on error in ravb_start_xmit() (diff) | |
| download | linux-fc1f8f4f310ac65b1337e2d7ba52ae4ff2b7c849.tar.xz linux-fc1f8f4f310ac65b1337e2d7ba52ae4ff2b7c849.zip | |
net: ipv6: send unsolicited NA if enabled for all interfaces
When arp_notify is set to 1 for either a specific interface or for 'all'
interfaces, gratuitous arp requests are sent. Since ndisc_notify is the
ipv6 equivalent to arp_notify, it should follow the same semantics.
Commit 4a6e3c5def13 ("net: ipv6: send unsolicited NA on admin up") sends
the NA on admin up. The final piece is checking devconf_all->ndisc_notify
in addition to the per device setting. Add it.
Fixes: 5cb04436eef6 ("ipv6: add knob to send unsolicited ND on link-layer address change")
Signed-off-by: David Ahern <dsa@cumulusnetworks.com>
Reviewed-by: Simon Horman <simon.horman@netronome.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
| -rw-r--r-- | net/ipv6/ndisc.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/net/ipv6/ndisc.c b/net/ipv6/ndisc.c index 7ebac630d3c6..cb1766724a4c 100644 --- a/net/ipv6/ndisc.c +++ b/net/ipv6/ndisc.c @@ -1749,7 +1749,8 @@ static int ndisc_netdev_event(struct notifier_block *this, unsigned long event, idev = in6_dev_get(dev); if (!idev) break; - if (idev->cnf.ndisc_notify) + if (idev->cnf.ndisc_notify || + net->ipv6.devconf_all->ndisc_notify) ndisc_send_unsol_na(dev); in6_dev_put(idev); break; |